From: | David Steele <david(at)pgmasters(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Petr Jelinek <petr(at)2ndquadrant(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PROPOSAL] Client Log Output Filtering |
Date: | 2016-03-11 14:52:26 |
Message-ID: | 56E2DBAA.5060503@pgmasters.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 3/10/16 11:07 AM, Tom Lane wrote:
> Petr Jelinek <petr(at)2ndquadrant(dot)com> writes:
>> The comment above errhidefromclient says "Only log levels below ERROR
>> can be hidden from the client." but use of the errhidefromclient(true)
>> actually does hide the error message from client, client just gets
>> failed query without any message when used with ERROR level.
>
> Um. That seems pretty broken --- I think it's a violation of the wire
> protocol spec.
>
> I notice though that we allow client_min_messages to be set to FATAL,
> which would be a different way of violating the protocol. Maybe we
> should reduce the max setting of that to ERROR?
This was the same conclusion I came to for the log_level setting in pgaudit.
I'll submit a proposal to hackers after 9.6 to make this change.
--
-David
david(at)pgmasters(dot)net
From | Date | Subject | |
---|---|---|---|
Next Message | David Steele | 2016-03-11 14:56:06 | Re: [PROPOSAL] Client Log Output Filtering |
Previous Message | Michael Paquier | 2016-03-11 14:48:56 | Re: proposal: get oldest LSN - function |