Re: [PROPOSAL] Client Log Output Filtering

From: David Steele <david(at)pgmasters(dot)net>
To: Petr Jelinek <petr(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PROPOSAL] Client Log Output Filtering
Date: 2016-03-10 14:08:42
Message-ID: 56E17FEA.2030800@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 3/9/16 7:37 PM, Petr Jelinek wrote:
> On 03/02/16 05:02, Robert Haas wrote:
>> On Mon, Feb 1, 2016 at 7:24 PM, David Steele <david(at)pgmasters(dot)net> wrote:
>>>
>>> I have attached a patch that adds an ereport() macro to suppress client
>>> output for a single report call (applies cleanly on 1d0c3b3). I'll also
>>> move it to the next CF.
>>
>> I don't see any reason not to accept this.
>>
>
> Yes, the idea seems sane.
>
> Looking at the code, this adds bool hide_from_client to edata which is
> not initialized in errstart so that needs to be fixed.

I figured this would take care of it:

MemSet(edata, 0, sizeof(ErrorData));

Since I want hide_from_client to default to false. Am I missing something?

--
-David
david(at)pgmasters(dot)net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Adrian Klaver 2016-03-10 14:17:37 Re: [HACKERS] How can we expand PostgreSQL ecosystem?
Previous Message Amit Langote 2016-03-10 14:08:39 Re: Parallel Aggregate