Re: Proposal: Generic WAL logical messages

On 08/03/16 21:21, Artur Zakirov wrote:
> I think here
>
>> +const char *
>> +logicalmsg_identify(uint8 info)
>> +{
>> + if (info & ~XLR_INFO_MASK == XLOG_LOGICAL_MESSAGE)
>> + return "MESSAGE";
>> +
>> + return NULL;
>> +}
>
> we should use brackets
>
> const char *
> logicalmsg_identify(uint8 info)
> {
> if ((info & ~XLR_INFO_MASK) == XLOG_LOGICAL_MESSAGE)
> return "MESSAGE";
>
> return NULL;
> }
>

Correct, fixed, thanks.

I also rebased this as there was conflict after the fixes to logical
decoding by Andres.

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services