Re: WAL log only necessary part of 2PC GID

From: Petr Jelinek <petr(at)2ndquadrant(dot)com>
To: Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WAL log only necessary part of 2PC GID
Date: 2016-03-09 14:26:11
Message-ID: 56E03283.8090201@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I wonder why you define the gidlen as uint32 when it would fit into
uint8 which in the current TwoPhaseFileHeader struct should be win of 8
bytes on padding (on 64bit). I think that's something worth considering
given that this patch aims to lower the size of the data.

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2016-03-09 14:27:04 Re: Proposal: RETURNING primary_key()
Previous Message Thom Brown 2016-03-09 14:21:11 Re: RFC: replace pg_stat_activity.waiting with something more descriptive