Re: Badly designed error reporting code in controldata_utils.c

From: Joe Conway <mail(at)joeconway(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Badly designed error reporting code in controldata_utils.c
Date: 2016-03-07 23:18:34
Message-ID: 56DE0C4A.2080300@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 03/07/2016 08:02 AM, Joe Conway wrote:
> On 03/06/2016 07:34 PM, Tom Lane wrote:
>> Joe Conway <mail(at)joeconway(dot)com> writes:
>>> On 03/06/2016 05:47 PM, Tom Lane wrote:
>>>> That's much better, but is there a reason you're using exit(2)
>>>> and not exit(EXIT_FAILURE) ?
>>
>>> Only because I was trying to stick with what was originally in
>>> src/bin/pg_controldata/pg_controldata.c
>>
>> Meh. It looks to me like the standard way to handle this
>> for code in src/common/ is exit(EXIT_FAILURE).
>
> I have no issue with using EXIT_FAILURE, but note:

Committed/pushed with exit(EXIT_FAILURE)

Joe

--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ian Barwick 2016-03-08 00:17:26 Re: Proposal: RETURNING primary_key()
Previous Message David Rowley 2016-03-07 23:05:40 Typo in logicaldecoding docs