Confusing with commit time usage in logical decoding

From: Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Confusing with commit time usage in logical decoding
Date: 2016-02-29 11:18:48
Message-ID: 56D42918.1010108@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

I read this message
http://www.postgresql.org/message-id/56D4197E.9050706@informatik.uni-kl.de

Is this a bug or a typo? In DecodeCommit() in decode.c instead of:

if (parsed->xinfo & XACT_XINFO_HAS_ORIGIN)
{
origin_lsn = parsed->origin_lsn;
commit_time = parsed->origin_timestamp;
}

should be:

if (parsed->xinfo & XACT_XINFO_HAS_ORIGIN)
{
origin_lsn = parsed->origin_lsn;
commit_time = parsed->origin_timestamp;
}
else
commit_time = parsed->xact_time;

--
Artur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-02-29 11:38:22 Re: Proposal: "Causal reads" mode for load balancing reads without stale data
Previous Message Alexander Korotkov 2016-02-29 10:42:03 Re: WIP: Access method extendability