Re: GIN data corruption bug(s) in 9.6devel

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: GIN data corruption bug(s) in 9.6devel
Date: 2016-02-24 12:40:51
Message-ID: 56CDA4D3.3000106@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 02/24/2016 06:56 AM, Robert Haas wrote:
> On Wed, Feb 24, 2016 at 9:17 AM, Tomas Vondra
> <tomas(dot)vondra(at)2ndquadrant(dot)com> wrote:
...
>> Are we going to anything about this? While the bug is present in 9.5 (and
>> possibly other versions), fixing it before 9.6 gets out seems important
>> because reproducing it there is rather trivial (while I've been unable to
>> reproduce it on 9.5).
>
> I'm not going to promise to commit anything here, because GIN is not
> usually my area, but could you provide a link to the email that
> contains the patch you think should be committed?

Sure. There are actually two candidate patches in two separate threads,
I'm nots sure which one is better. Based on the testing both seem to fix
the issue and the "pending lock" patch produces much smaller indexes (at
least in my benchmark):

[1] http://www.postgresql.org/message-id/56041B26.2040902@sigaev.ru
[2]
http://www.postgresql.org/message-id/CAMkU=1w7Uu1GZ8N0bxMykRLgTh-uPH+GPHfhMNeryZPCv7fqdA@mail.gmail.com

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-02-24 13:44:22 Re: RFC: replace pg_stat_activity.waiting with something more descriptive
Previous Message Craig Ringer 2016-02-24 10:02:09 Re: WIP: Failover Slots