Re: pgsql: Improve error reporting when location specified by postgres -D d

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Improve error reporting when location specified by postgres -D d
Date: 2016-02-05 01:42:30
Message-ID: 56B3FE06.4040903@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2/2/16 11:26 PM, Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> + if (configdir && stat(configdir, &stat_buf) != 0)
>> + {
>> + write_stderr("%s: could not access \"%s\": %s\n",
>> + progname,
>> + configdir,
>> + strerror(errno));
>
> Perhaps "could not access directory ..."? This doesn't seem to follow the
> message style guideline about specifying what sort of object you're
> complaining about.

Done.

Somehow I was under the mistaken impression that one could also specific
a config file name there.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2016-02-05 03:08:15 pgsql: When modifying a foreign table, initialize tableoid field proper
Previous Message Peter Eisentraut 2016-02-05 01:41:52 pgsql: Improve error message