Re: Minor code improvements to create_foreignscan_plan/ExecInitForeignScan

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Minor code improvements to create_foreignscan_plan/ExecInitForeignScan
Date: 2016-01-28 12:55:33
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2016/01/28 18:15, Alvaro Herrera wrote:
> Etsuro Fujita wrote:
>> On 2016/01/28 12:13, Robert Haas wrote:

>>> I don't think this is a good idea. Most of the time, no system
>>> columns will be present, and we'll just be scanning the Bitmapset
>>> twice rather than once. Sure, that doesn't take many extra cycles,
>>> but if the point of all this is to micro-optimize this code, that
>>> particular change is going in the wrong direction.

>> I thought that is a good idea, considering the additional overhead is
>> little, because that would be useful for some use-cases. But I think we
>> need more discussions about that, so if there are no objections from Alvaro
>> (or anyone), I'll leave that part as-is.

> I'm happy to defer.

Done. Attached is an updated version of the patch.

Best regards,
Etsuro Fujita

Attachment Content-Type Size
create-foreignscan-plan-v5.patch application/x-patch 3.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-01-28 12:57:59 Re: Template for commit messages
Previous Message Michael Paquier 2016-01-28 12:39:13 Comment typos in source code: s/thats/that is/