| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Minor code improvements to create_foreignscan_plan/ExecInitForeignScan |
| Date: | 2016-01-28 09:15:28 |
| Message-ID: | 20160128091528.GA722621@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Etsuro Fujita wrote:
> On 2016/01/28 12:13, Robert Haas wrote:
> >I don't think this is a good idea. Most of the time, no system
> >columns will be present, and we'll just be scanning the Bitmapset
> >twice rather than once. Sure, that doesn't take many extra cycles,
> >but if the point of all this is to micro-optimize this code, that
> >particular change is going in the wrong direction.
>
> I thought that is a good idea, considering the additional overhead is
> little, because that would be useful for some use-cases. But I think we
> need more discussions about that, so if there are no objections from Alvaro
> (or anyone), I'll leave that part as-is.
I'm happy to defer.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2016-01-28 09:31:42 | Re: extend pgbench expressions with functions |
| Previous Message | Pavel Stehule | 2016-01-28 09:10:58 | Re: [PATCH] better systemd integration |