| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Ajin Cherian <itsajin(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improve pg_sync_replication_slots() to wait for primary to advance |
| Date: | 2025-12-10 13:34:26 |
| Message-ID: | 56A9D432-28C9-4954-B3D0-2CCBCF74909F@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Dec 10, 2025, at 20:23, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Dec 10, 2025 at 10:37 AM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>>
>> Attaching v34 addressing the above comments.
>>
>
> 0001 looks mostly good to me. I have made minor edits in the comments
> and added error_code for one of the error messages. Please check
> attached and let me know what you think?
>
> --
> With Regards,
> Amit Kapila.
> <v35-0001-Signal-backends-running-pg_sync_replication_slot.patch>
I saw you have integrated the missed change from the last push into v35, and v35 looks good to me.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2025-12-10 13:35:18 | Re: Improve comment in function GetPublicationRelations |
| Previous Message | Robert Haas | 2025-12-10 13:33:11 | Re: pg_plan_advice |