| From: | Torsten Zühlsdorff <mailinglists(at)toco-domains(dot)de> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add generate_series(date,date) and generate_series(date,date,integer) |
| Date: | 2016-01-27 08:07:31 |
| Message-ID: | 56A87AC3.2070802@toco-domains.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 26.01.2016 13:53, Michael Paquier wrote:
>>>> Imagine for example a script that in some rare cases passes happens to
>>>> pass infinity into generate_series() - in that case I'd much rather error
>>>> out than wait till the end of the universe.
>>>>
>>>> So +1 from me to checking for infinity.
>>>>
>>>
>>> +1
>>>
>>> ERROR infinite result sets are not supported, yet
>>
>>
>> Maybe we should skip the "yet". Or do we really plan to support them in
>> (infinite) future? ;)
>>
>> +1 from me to check infinity also.
>
> Something like the patch attached would be fine? This wins a backpatch
> because the query continuously running eats memory, no?
Looks fine to me.
(Minor mention: is there no newline needed between the tests?)
Greetings,
Torsten
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2016-01-27 08:39:37 | Re: extend pgbench expressions with functions |
| Previous Message | Fujii Masao | 2016-01-27 07:42:22 | Re: Existence check for suitable index in advance when concurrently refreshing. |