Re: COPY (... tab completion

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: COPY (... tab completion
Date: 2016-01-19 00:57:08
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 01/11/2016 02:01 AM, Peter Eisentraut wrote:
> I think this would be a useful addition. A couple of problems:

Thanks for the review. A new version is attached.

> This change in the comment doesn't make sense to me and doesn't seem to
> match the code:
> - /* If we have COPY [BINARY] <sth>, complete it with "TO" or "FROM" */
> + /* If we have COPY|BINARY <sth>, complete it with "TO" or "FROM" */

Fixed. As Tom correctly guessed this was the result of a mistake when

> The list of commands to allow as the "query" inside the parentheses is
> documented to be: SELECT, VALUES, INSERT, UPDATE or DELETE; and actually
> TABLE should also work. Your list doesn't include all of those. So
> please adjust that.

Fixed. And TABLE works too.


Attachment Content-Type Size
copy-tab-compleition-v2.patch text/x-diff 1.3 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Karlsson 2016-01-19 01:12:00 Re: COPY (... tab completion
Previous Message Jim Nasby 2016-01-19 00:55:47 Re: Interesting read on SCM upending software and hardware architecture