Re: Removing service-related code in pg_ctl for Cygwin

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, marco(dot)atzeri(at)gmail(dot)com
Subject: Re: Removing service-related code in pg_ctl for Cygwin
Date: 2016-01-18 21:27:11
Message-ID: 569D58AF.4000303@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 01/18/2016 03:46 PM, Alvaro Herrera wrote:
> Andrew Dunstan wrote:
>>
>> On 01/18/2016 12:38 PM, Alvaro Herrera wrote:
>>> Andrew Dunstan wrote:
>>>
>>>> I think we can be a bit more adventurous and remove all the Cygwin-specific
>>>> code. See attached patch, which builds fine on buildfarm cockatiel.
>>> Hopefully you also tested that it builds under MSVC :-)
>> Why would I? This isn't having the slightest effect on MSVC builds.
> You never know ... you might have inadvertently broken some WIN32 block.
>

If you can point out a line where that might be true I'll test it ;-)

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2016-01-18 21:29:46 Re: system mingw not recognized
Previous Message Robert Haas 2016-01-18 21:21:35 Re: plpgsql - DECLARE - cannot to use %TYPE or %ROWTYPE for composite types