Re: Removing service-related code in pg_ctl for Cygwin

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Cc: marco(dot)atzeri(at)gmail(dot)com
Subject: Re: Removing service-related code in pg_ctl for Cygwin
Date: 2016-01-18 17:32:27
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 01/14/2016 12:38 AM, Michael Paquier wrote:
> Hi all,
> Beginning a new thread seems more adapted regarding $subject but
> that's mentioned here as well:
> It happens based on some investigation from Andrew that cygwin does
> not need to use the service-related code, aka register/unregister
> options or similar that are proper to WIN32 and rely instead on
> cygrunsrv with a SYSV-like init file to manage the service. Based on
> my tests with cygwin, I am able to see as well that a server started
> within a cygwin session is able to persist even after it is closed,
> which is kind of nice and I think that it is a additional reason to
> not use the service-related code paths. Hence what about the following
> patch, that makes cygwin behave like any *nix OS when using pg_ctl?
> This simplifies a bit the code.
> Marco, as I think you do some packaging for Postgres in Cygwin, and
> others, does that sound acceptable?

I think we can be a bit more adventurous and remove all the
Cygwin-specific code. See attached patch, which builds fine on buildfarm



Attachment Content-Type Size
cygwin-removal-service-master-2.patch text/x-diff 6.3 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-01-18 17:34:13 Re: Combining Aggregates
Previous Message Robert Haas 2016-01-18 17:13:50 Re: Trivial fixes for some IDENTIFICATION comment lines