Re: exposing pg_controldata and pg_config as functions

From: Joe Conway <mail(at)joeconway(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Josh Berkus <josh(dot)berkus(at)pgexperts(dot)com>
Subject: Re: exposing pg_controldata and pg_config as functions
Date: 2016-01-17 22:24:46
Message-ID: 569C14AE.5080506@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 01/16/2016 06:02 AM, Michael Paquier wrote:
> On Wed, Dec 30, 2015 at 9:08 AM, Joe Conway <mail(at)joeconway(dot)com> wrote:
>> 1) Change NextXID output format from "%u/%u" to "%u:%u"
>> (see recent hackers thread)
>
> ! printf(_("Latest checkpoint's NextXID: %u/%u\n"),
> ControlFile.checkPointCopy.nextXidEpoch,
> ControlFile.checkPointCopy.nextXid);
> printf(_("Latest checkpoint's NextOID: %u\n"),
> --- 646,652 ----
> ControlFile.checkPointCopy.ThisTimeLineID);
> printf(_("Latest checkpoint's full_page_writes: %s\n"),
> ControlFile.checkPointCopy.fullPageWrites ? _("on") : _("off"));
> ! printf(_("Latest checkpoint's NextXID: %u:%u\n"),
> This should be definitely a separate patch.

Ok. Notwithstanding Simon's reply, there seems to be consensus that this
is the way to go. Will commit it this way unless some additional
objections surface in the next day or so.

Joe

--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joe Conway 2016-01-17 22:29:05 Re: exposing pg_controldata and pg_config as functions
Previous Message Joe Conway 2016-01-17 22:20:32 Re: dblink: add polymorphic functions.