| From: | Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fuzzy substring searching with the pg_trgm extension |
| Date: | 2016-01-15 09:53:52 |
| Message-ID: | 5698C1B0.7060102@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12.01.2016 02:31, Alvaro Herrera wrote:
> I gave a quick look through the patch and noticed a few minor things
> while trying to understand it.
>
> I think the test corpus isn't particularly interesting for how big it
> is. I'd rather have (a) a small corpus (say 100 words) with which to do
> detailed regression testing, and (b) some larger document for more
> extensive testing. I'm not sure (b) is actually necessary.
>
> Overall I think the new functions could stand a lot more commentary.
>
Thank you for a review. I will send fixed patch in a few days.
--
Artur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2016-01-15 10:00:25 | Re: Minor code improvements to create_foreignscan_plan/ExecInitForeignScan |
| Previous Message | Amit Kapila | 2016-01-15 09:27:53 | Re: POC: Cache data in GetSnapshotData() |