| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, masao(dot)fujii(at)gmail(dot)com |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Some bugs in psql_complete of psql |
| Date: | 2016-01-13 02:46:34 |
| Message-ID: | 5695BA8A.3060401@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/22/15 4:44 AM, Kyotaro HORIGUCHI wrote:
> 1. 0001-Fix-tab-complete-of-CREATE-INDEX.patch
>
> Fixes completion for CREATE INDEX in ordinary way.
This part has been fixed in another thread. Please check whether that
satisfies all your issues.
> 3. 0002-Fix-tab-completion-for-DROP-INDEX.patch
>
> Fix of DROP INDEX completion in the type-2 way.
I agree that we could use completion support for DROP INDEX
CONCURRENTLY, but I would rather not throw IF NOT EXISTS into the same
patch. We don't have support for IF NOT EXISTS anywhere else. If you
think about, it's rather unnecessary, because tab completion will
determine for you whether an object exists.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2016-01-13 03:17:26 | Re: checkpointer continuous flushing |
| Previous Message | David Rowley | 2016-01-13 01:47:40 | Re: WIP: Covering + unique indexes. |