| From: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Ildus Kurbangaliev <i(dot)kurbangaliev(at)postgrespro(dot)ru>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: [PATCH] Refactoring of LWLock tranches |
| Date: | 2016-01-05 13:54:22 |
| Message-ID: | 568BCB0E.4030104@redhat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01/05/2016 08:04 AM, Amit Kapila wrote:
> I am not aware of such cases, however the reason I have kept it was for
> backward-compatability, but now I have removed it in the attached patch.
>
> Apart from that, I have updated the docs to reflect the changes related
> to new API's.
>
xfunc.sgml:
+ after allocating LWLocks, verify that the number of
allocated
+ LWLocks is same as requested;
Did you mean to put this check in ?
lwlock.c:
+ * GetLWLockAddinTranche - returns the base address of LWLock from the
+ * specified tranche.
+ *
+ * Caller needs to retrieve the requested number of LWLocks starting from
+ * the base lock address returned by this API. This can be used for
+ * tranches that are requested by using RequestAddinLWLockTranche() API.
+ */
+LWLockPadded *
+GetLWLockAddinTranche(const char *tranche_name)
+{
I understand why the signature is the way it is, but
LWLock *
GetLWLockAddinTranche(const char *tranche_name)
would be nicer to work with for extensions IMHO. Not likely worth the
trouble though.
Thanks for working on this.
Best regards,
Jesper
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chapman Flack | 2016-01-05 14:18:00 | Re: dynloader.h missing in prebuilt package for Windows? |
| Previous Message | Amit Kapila | 2016-01-05 13:04:12 | Re: [PATCH] Refactoring of LWLock tranches |