Re: 9.5 BLOCKER: regrole and regnamespace and quotes

From: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: 9.5 BLOCKER: regrole and regnamespace and quotes
Date: 2016-01-04 05:19:45
Message-ID: 568A00F1.8040607@BlueTreble.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 1/3/16 11:05 PM, Michael Paquier wrote:
>> I'll take a look, but Michael, if you have time to review, an extra set
>> >of eyeballs wouldn't hurt. There is no margin for error right now.
> I'm just on it:) Will update in a couple of minutes, I noticed some
> stuff in Jim's patch.

BTW, in case you miss it... I was inconsistent with the list
length_names checks... one is

if (list_length(names) > 1)

the other is

if (list_length(names) != 1)

(stringToQualifiedNameList() can't actually return a 0 length list and
IIRC there was another place doing a > check.)
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-01-04 05:24:25 Re: 9.5 BLOCKER: regrole and regnamespace and quotes
Previous Message Michael Paquier 2016-01-04 05:05:39 Re: 9.5 BLOCKER: regrole and regnamespace and quotes