Re: pg_controldata/pg_resetxlog "Latest checkpoint's NextXID" format

From: José Luis Tallón <jltallon(at)adv-solutions(dot)net>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Joe Conway <mail(at)joeconway(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: pg_controldata/pg_resetxlog "Latest checkpoint's NextXID" format
Date: 2015-12-29 14:17:44
Message-ID: 56829608.1030408@adv-solutions.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12/29/2015 01:18 PM, Heikki Linnakangas wrote:
> On 29/12/15 07:14, Joe Conway wrote:
>> I wonder why "Latest checkpoint's NextXID" is formated like this:
>>
>> 8<-------------------------
>> printf(_("Latest checkpoint's NextXID: %u/%u\n"),
>> ControlFile.checkPointCopy.nextXidEpoch,
>> ControlFile.checkPointCopy.nextXid);
>> 8<-------------------------
>>
>> Shouldn't it use "%X/%X", same as e.g. "Prior checkpoint location" and
>> all the other XIDs?
>
> No. The "locations" in the output are WAL locations. Those are
> customarily printed with %X/%X. But NextXID is a transaction ID, those
> are printed in decimal, with %u.

But Joe has a point here.... Others could also be confused if he doubted
about this.

"Latest checkpoint's NextXID: %u:%u\n", maybe ??
(slash becomes colon)

Worst part: fuzzies the translations unnecesarily

/ J.L.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2015-12-29 14:55:41 Re: Additional role attributes && superuser review
Previous Message Michael Paquier 2015-12-29 14:14:16 Re: Making tab-complete.c easier to maintain