From: | Phil Krylov <phil(at)krylov(dot)eu> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | [PATCH] pg_ctl should not truncate command lines at 1024 characters |
Date: | 2021-09-02 21:36:13 |
Message-ID: | 567e199c6b97ee19deee600311515b86@krylov.eu |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello,
Lacking a tool to edit postgresql.conf programmatically, people resort
to passing cluster options on the command line. While passing all
non-default options in this way may sound like an abuse of the feature,
IMHO pg_ctl should not blindly truncate generated command lines at
MAXPGPATH (1024 characters) and then run that, resulting in:
/bin/sh: Syntax error: end of file unexpected (expecting word)
pg_ctl: could not start server
Examine the log output.
The attached patch tries to fix it in the least intrusive way.
While we're at it, is it supposed that pg_ctl is a very short-lived
process and is therefore allowed to leak memory? I've noticed some
places where I would like to add a free() call.
-- Ph.
Attachment | Content-Type | Size |
---|---|---|
0001-pg_ctl-should-not-truncate-command-lines-at-1024-cha.patch | text/x-diff | 7.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Bossart, Nathan | 2021-09-02 21:52:22 | Re: .ready and .done files considered harmful |
Previous Message | Andrew Dunstan | 2021-09-02 21:18:56 | Re: a misbehavior of partition row movement (?) |