| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Gavin Flower <GavinFlower(at)archidevsys(dot)co(dot)nz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Adam Brightwell <adam(dot)brightwell(at)crunchydatasolutions(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Additional role attributes && superuser review |
| Date: | 2015-12-24 06:59:21 |
| Message-ID: | 567B97C9.1070003@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2015/12/23 7:23, Stephen Frost wrote:
> Updated patch attached. I'll give it another good look and then commit
> it, barring objections.
Just a minor nitpick about a code comment -
/*
+ * Check that the user is not trying to create a role in the reserved
+ * "pg_" namespace.
+ */
+ if (IsReservedName(stmt->role))
The wording may be slightly confusing, especially saying "... in ...
namespace". ISTM, "namespace" is fairly extensively used around the code
to mean something like "a schema's namespace".
Could perhaps be reworded as:
/*
+ * Check that the user is not trying to create a role with reserved
+ * name, ie, one starting with "pg_".
If OK, there seems to be one more place further down in the patch with
similar wording.
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2015-12-24 07:36:48 | Re: On-demand running query plans using auto_explain and signals |
| Previous Message | Fabien COELHO | 2015-12-24 06:40:19 | Re: pgbench - allow backslash-continuations in custom scripts |