| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Amir Rohan <amir(dot)rohan(at)zoho(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Greg Smith <gsmith(at)gregsmith(dot)com> |
| Subject: | Re: Re: In-core regression tests for replication, cascading, archiving, PITR, etc. |
| Date: | 2015-11-29 22:57:17 |
| Message-ID: | 565B82CD.6040602@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/29/2015 04:28 PM, Noah Misch wrote:
> +BEGIN
> +{
> + $windows_os = $Config{osname} eq 'MSWin32' || $Config{osname} eq 'msys';
> +
> + # Determine output directories, and create them. The base path is the
> + # TESTDIR environment variable, which is normally set by the invoking
> + # Makefile.
> + $tmp_check = $ENV{TESTDIR} ? "$ENV{TESTDIR}/tmp_check" : "tmp_check";
> + $log_path = "$tmp_check/log";
> +
> + mkdir $tmp_check;
> + mkdir $log_path;
> Never mutate the filesystem in a BEGIN block, because "perl -c" runs BEGIN
> blocks. (Likewise for the BEGIN block this patch adds to TestLib.)
Yeah, those two lines might belong in an INIT block. "perldoc perlmod"
for details.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rodrigo Hjort | 2015-11-30 02:19:56 | Help on creating C function that reads int2[] (using "int2vector") |
| Previous Message | David Rowley | 2015-11-29 22:09:26 | Re: WIP: Make timestamptz_out less slow. |