| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: psql completion for ids in multibyte string |
| Date: | 2015-11-05 09:32:59 |
| Message-ID: | 563B224B.3020400@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Horiguchi-san,
On 2015/11/05 18:10, Kyotaro HORIGUCHI wrote:
> Hello. I don't know whether this is a bug fix or improvement,
Would it be 50-50? :-)
...
>
> During the investigation into this issue, I found a mistake in
> the comment for PQmblen. It give the byte length of the character
> at the point, not word. The attached patche also fixes it.
>
>> /*
>> * returns the byte length of the word beginning s, using the
>> * specified encoding.
>> */
>> int
>> PQmblen(const char *s, int encoding)
>
In the following change,
- * returns the byte length of the word beginning s, using the
- * specified encoding.
+ * returns the byte length of the character beginning s, using the specified
+ * encoding.
Just a minor nitpick -
... character beginning *at* s ...?
If so, there would be one more instance to fix.
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Evgeniy Shishkin | 2015-11-05 09:45:31 | Re: Yet another abort-early plan disaster on 9.3 |
| Previous Message | Andres Freund | 2015-11-05 09:23:24 | Re: OS X El Capitan and DYLD_LIBRARY_PATH |