Re: [PATCH] Remove obsolete tupDesc assignment in extended statistics

From: Denis Rodionov <denis(dot)rodionov(at)tantorlabs(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Remove obsolete tupDesc assignment in extended statistics
Date: 2026-07-29 14:52:48
Message-ID: 5637e8a6-c5d6-4082-97d7-2f835d23a4e7@tantorlabs.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 6/10/26 08:21, Michael Paquier wrote:
> Planting an assertion at this location feels OK here. (I need to
> remember to look at that again once v20 opens for business, noting
> that down now..)
> --
> Michael

Hi Michael,

Thanks for the previous review.
I have attached two small patches:
- v3 removes the obsolete tupDesc assignment in extended statistics
and retains the assertion suggested in your review. It has been rebased
on the current master.
- v1 removes a stray semicolon after import_expressions(), which I
noticed while working in the same area.

The second change is independent, but small enough that I have included
it here rather than starting a separate thread.

Could you please take a look and commit them if they look good?

Best regards,
Denis Rodionov,
Tantor Labs LLC,
https://tantorlabs.com/

Attachment Content-Type Size
v3-0001-Remove-obsolete-tupDesc-assignment-in-extended-st.patch text/x-patch 1.4 KB
v1-0001-Remove-stray-semicolon-after-import_expressions.patch text/x-patch 786 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Peter Geoghegan 2026-07-29 14:47:16 Re: nbtree backwards scan test coverage