Re: [patch] extensions_path GUC

From: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, <strk(at)keybit(dot)net>
Subject: Re: [patch] extensions_path GUC
Date: 2015-10-23 16:26:03
Message-ID: 562A5F9B.5070801@BlueTreble.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 10/23/15 11:02 AM, Heikki Linnakangas wrote:
> On 10/23/2015 02:59 PM, Michael Paquier wrote:
>> On Fri, Oct 23, 2015 at 7:46 PM, Heikki Linnakangas wrote:
>>> On 10/23/2015 01:33 PM, Sandro Santilli wrote:
>>> In short, I don't think just setting extensions_path is enough or
>>> desirable,
>>> but I would welcome a patch that makes "make check" work for
>>> extensions, by
>>> creating a temporary installation.
>>
>> Isn't that the existing EXTRA_INSTALL?
>
> No. The problem is that "make check" doesn't work extensions built
> outside the server source tree. You get an error:
>
> "make check" is not supported.
> Do "make install", then "make installcheck" instead.

I would love it if make check worked. make installcheck adds extra
effort to extension develoopment, not to mention leaving your actual
install in a less than pristine state.

Possibly related to this... I'd also like to have other options for
running unit tests, besides pg_regress. I looked at it briefly and the
big PITA about doing it was having to manage the temporary database (and
ideally temporary cluster). If standing those up was separated from
pg_regress it would make it a lot easier for someone to customize how
testing works under PGXS.
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2015-10-23 16:29:10 Re: Making tab-complete.c easier to maintain
Previous Message Robert Haas 2015-10-23 16:15:01 Re: Making tab-complete.c easier to maintain