pg_recvlogical fixes

From: Euler Taveira <euler(at)timbira(dot)com(dot)br>
To: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: pg_recvlogical fixes
Date: 2015-10-21 14:52:31
Message-ID: 5627A6AF.30301@timbira.com.br
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

While testing wal2json, I faced some problems with pg_recvlogical.
Attached is a serie of patches that can improve pg_recvlogical. Patches
#2 and #3 are bugfixes (and should be applied to 9.5 too). Patch #1 is
not mandatory to 9.5.

Short description:

#1: add a bunch of checks to complain when using an option that is not
available in the specified action;
#2: there is a wrong check because startpos option can be specified with
--create-slot;
#3: doesn't ignore startpos in --create-slot because that action could
be specified together with --start action (that uses that option);

--
Euler Taveira Timbira - http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Attachment Content-Type Size
0003-Fix-a-startpos-override.patch text/x-patch 908 bytes
0002-Fix-startpos-parameter-check.patch text/x-patch 1.2 KB
0001-pg_recvlogical-Tighten-checks-for-action-parameters.patch text/x-patch 6.4 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2015-10-21 14:53:44 Re: WAL logging problem in 9.4.3?
Previous Message Andres Freund 2015-10-21 13:35:03 Re: checkpointer continuous flushing