ATT_FOREIGN_TABLE and ATWrongRelkindError()

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: ATT_FOREIGN_TABLE and ATWrongRelkindError()
Date: 2015-10-21 05:51:08
Message-ID: 562727CC.5000100@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

This may just be nitpicking but I noticed that ATWrongRelkindError() could
emit a better message in case of such errors during ALTER COLUMN DEFAULT
and ALTER COLUMN SET STORAGE than "%s is of the wrong type" which is what
it would emit now. Just need to add a couple of cases to the switch there:

+ case ATT_TABLE | ATT_VIEW | ATT_FOREIGN_TABLE:
+ msg = _("\"%s\" is not a table, view or foreign table");
+ break;

+ case ATT_TABLE | ATT_MATVIEW | ATT_FOREIGN_TABLE:
+ msg = _("\"%s\" is not a table, materialized view, or foreign table");
+ break;

Attached adds those.

Thanks,
Amit

Attachment Content-Type Size
at-wrong-relkind-error-fix.patch text/x-diff 1.0 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-10-21 06:54:28 Re: [PATCH v3] GSSAPI encryption support
Previous Message Fabien COELHO 2015-10-21 05:49:23 Re: checkpointer continuous flushing