Re: plpython is broken for recursive use

From: Josh Berkus <josh(at)agliodbs(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: plpython is broken for recursive use
Date: 2015-10-15 21:16:15
Message-ID: 5620179F.6060102@agliodbs.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 10/15/2015 01:10 PM, Tom Lane wrote:
> I think this means that we should get rid of proc->globals and instead
> manufacture a new globals dict locally in each call to PLy_exec_function
> or PLy_exec_trigger. For SETOF functions it would be necessary to keep
> the globals dict reference somewhere in the FunctionCallInfo struct,
> probably. Not sure about cleaning up after an error that occurs between
> SETOF callbacks --- we might need plpython to grow an at-abort callback to
> do decref's on unreleased dicts.

Don't people currently specifically treat the state of the globals dict
as a feature? That is, make use of the fact that you can store
session-persistent data in it?

--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2015-10-15 21:30:38 Re: plpython is broken for recursive use
Previous Message Tom Lane 2015-10-15 20:10:34 plpython is broken for recursive use