Re: Less than ideal error reporting in pg_stat_statements

On 10/04/2015 06:16 PM, Tom Lane wrote:
> Peter Geoghegan <pg(at)heroku(dot)com> writes:
>> To be clear: I wasn't sure why you though I falsely count entries with
>> dropped texts within entry_dealloc().
> In the existing^H^H^Hprevious code, dropped-text entries would essentially
> act as length-zero summands in the average calculation, whereas I think
> we agree that they ought to be ignored; otherwise they decrease the
> computed mean and thereby increase the probability of (useless) GC cycles.
> In the worst case where the hashtable is mostly dropped-text entries,
> which would for instance be the prevailing situation shortly after a GC
> failure, we'd be calculating ridiculously small mean values and that'd
> prompt extra GC cycles no?
>
>

Sorry, I'm a bit late to this party. Does what you have committed mean
people are less likely to see "Out of Memory" coming from
pg_stat_statements? If not, what can be done about them short of a
restart? And what bad effects follow from an event generating them?

The docs seem to be quite silent on these points.

cheers

andrew