Re: Badly designed error reporting code in controldata_utils.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Badly designed error reporting code in controldata_utils.c
Date: 2016-03-07 03:34:36
Message-ID: 5600.1457321676@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Joe Conway <mail(at)joeconway(dot)com> writes:
> On 03/06/2016 05:47 PM, Tom Lane wrote:
>> That's much better, but is there a reason you're using exit(2)
>> and not exit(EXIT_FAILURE) ?

> Only because I was trying to stick with what was originally in
> src/bin/pg_controldata/pg_controldata.c

Meh. It looks to me like the standard way to handle this
for code in src/common/ is exit(EXIT_FAILURE).

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-03-07 03:43:47 Re: WIP: Upper planner pathification
Previous Message Amit Kapila 2016-03-07 03:28:59 Re: WIP: Upper planner pathification