| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> |
| Cc: | SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [Bug] Add the missing RTE_GRAPH_TABLE case to transformLockingClause() |
| Date: | 2026-07-09 08:18:53 |
| Message-ID: | 55f40114-0b00-4c6d-919d-c58641133d2b@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10.06.26 14:49, Ashutosh Bapat wrote:
>> Attached is v2-0001, rebased on master and addressing
>> the comments you added in case we plan on parking the feature
>> work for once v20 opens.
> Thanks. I revised it a bit. Reworded the commit message to describe
> user facing behaviour instead of the internals, which are quite
> obvious from the code changes. Other cases in transformLockingClause()
> don't mention XXX, they just have ereport(). Removed that comment.
> Also massaged comments in the test - we usually don't describe the
> expected behaviour or error when it is obvious from the output.
> Attached revised patch.
Committed.
I also modified the comment that said "ignore JOIN, SPECIAL, ..." to
just say "ignore all other RTE kinds", because keeping that kind of list
up to date is silly. (RTE_SPECIAL hasn't existed in a long time.)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2026-07-09 08:32:08 | Re: [PATCH] Fix null pointer dereference in PG19 |
| Previous Message | Zhijie Hou (Fujitsu) | 2026-07-09 08:08:31 | RE: Parallel Apply |