| From: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Maxim Orlov <orlovmg(at)gmail(dot)com> |
| Cc: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Japin Li <japinli(at)hotmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15) |
| Date: | 2023-11-27 07:00:00 |
| Message-ID: | 55d8800f-4a80-5256-1e84-246fbe79acd0@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello Alexander,
27.11.2023 02:43, Alexander Korotkov wrote:
> v61 looks good to me. I'm going to push it as long as there are no objections.
>
I've looked at the patch set and found a typo:
occured
And a warning:
$ CC=gcc-12 CFLAGS="-Wall -Wextra -Wno-unused-parameter -Wno-sign-compare -Wno-clobbered
-Wno-missing-field-initializers" ./configure -q && make -s
slru.c:63:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]
63 | static int inline
| ^~~~~~
Maybe it's worth fixing before committing...
Best regards,
Alexander
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii.Yuki@df.MitsubishiElectric.co.jp | 2023-11-27 07:04:07 | RE: Partial aggregates pushdown |
| Previous Message | Masahiko Sawada | 2023-11-27 06:45:18 | Re: [PoC] Improve dead tuple storage for lazy vacuum |