| From: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David E(dot) Wheeler" <david(at)kineticode(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Me Chai Swee <mech(at)me(dot)com> |
| Subject: | Re: tsvector work with citext |
| Date: | 2015-09-17 12:51:53 |
| Message-ID: | 55FAB769.4020509@sigaev.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> However, it does seem like this function is not implementing its
> specification. Why isn't it just "IsBinaryCoercible(typid, TEXTOID)"?
Oversight, I suppose. is_text_type() was introduced by
commit 635aaab278afc1af972a4b6a55ff632ab763505d
Author: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Date: Tue Apr 8 18:20:29 2008 +0000
Fix tsvector_update_trigger() to be domain-friendly: it needs to allow all
the columns it works with to be domains over the expected type, not just
exactly the expected type. In passing, fix ts_stat() the same way.
Per report from Markus Wollny.
Will fix. Suppose, is_expected_type() could be replaced to IsBinaryCoercible too.
--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Teodor Sigaev | 2015-09-17 13:17:58 | Re: tsvector work with citext |
| Previous Message | Robert Haas | 2015-09-17 12:14:05 | Re: On-demand running query plans using auto_explain and signals |