Re: [COMMITTERS] pgsql: Fix an O(N^2) problem in foreign key references.

From: Jan Wieck <jan(at)wi3ck(dot)info>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kevin Grittner <kgrittn(at)postgresql(dot)org>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Fix an O(N^2) problem in foreign key references.
Date: 2015-09-15 15:35:27
Message-ID: 55F83ABF.2080609@wi3ck.info
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 09/15/2015 10:58 AM, Tom Lane wrote:
> I wrote:
>> Jan Wieck <jan(at)wi3ck(dot)info> writes:
>>> I'm able to reproduce that failure with CLOBBER_CACHE_ALWAYS and it
>>> definitely is caused by this commit. Do you want to back it out for the
>>> time being? Kevin is on vacation right now.
>
>> I'll take a look today, and either fix it if I can find the problem
>> quickly or back it out.
>
> The answer is "back it out", because this patch is fundamentally and
> irretrievably broken. You can't just clobber the hashtable like that,
> because there are very possibly active uses of hashtable entries in
> outer function call levels.

Ok.

Would it be appropriate to use (Un)RegisterXactCallback() in case of
detecting excessive sequential scanning of that cache and remove all
invalid entries from it at that time?

Regards, Jan

--
Jan Wieck
Senior Software Engineer
http://slony.info

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2015-09-15 15:54:34 Re: [COMMITTERS] pgsql: Fix an O(N^2) problem in foreign key references.
Previous Message Tom Lane 2015-09-15 15:09:27 pgsql: Revert "Fix an O(N^2) problem in foreign key references".

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-09-15 15:45:27 Re: Can extension build own SGML document?
Previous Message Dean Rasheed 2015-09-15 15:33:23 Re: RLS open items are vague and unactionable