|From:||Heikki Linnakangas <hlinnaka(at)iki(dot)fi>|
|Subject:||Testing WAL replay by comparing before and after images again|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
I rerun my little testing tool that compares buffer page contents after
every modification, in master and in WAL replay. Previously discussed
Here's an updated version of my original hack, for current git master.
(Michael posted less-hacky versions of that, but unfortunately I haven't
gotten around to review his stuff.)
I did not find any new bugs. There were a couple of false positives
however. Firstly, the post-processing tool needed to be taught that BRIN
pages can have the PD_HAS_FREE_LINES flag set, and ignore that (like it
does for heap and other indexam pages).
Another issue was with the new speculative insertions. Replaying a
speculative insertion record sets the tuple's CTID to point to itself,
like in a regular insertion. But in the original system, the CTID is set
to a special speculative insertion token. The tool flagged up that
I propose the attached patch
(mark-speculative-insertions-in-replay.patch) to fix that in the replay
routine. This is not required for correctness, but helps this tool, and
seems like a good idea for debugging purposes anyway.
|Next Message||Thomas Munro||2015-09-04 13:21:17||Making tab-complete.c easier to maintain|
|Previous Message||Teodor Sigaev||2015-09-04 12:11:12||Re: [PATCH] Microvacuum for gist.|