| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: BRIN INDEX value |
| Date: | 2015-09-04 05:06:08 |
| Message-ID: | 55E926C0.90907@lab.ntt.co.jp |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/4/2015 2:04 PM, Tatsuo Ishii wrote:
>> One thing I imagine we could do is to change the signature of
>> summrize_range() to also include heapNumBlks which its (only) caller
>> brinsummarize() already computes. It will look like:
>>
>> static void summarize_range(IndexInfo *indexInfo, BrinBuildState *state,
>> Relation heapRel,
>> BlockNumber heapBlk,
>> BlockNumber heapNumBlks);
>>
>> I'd think changing summarize_range()'s signature would be relatively
>> easier/safer.
>
> Yeah, sounds good.
Here's a patch to do that.
Thanks,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| brin-heap-rangescan-fix-2.patch | text/x-diff | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro HORIGUCHI | 2015-09-04 05:11:14 | Re: pgbench - allow backslash-continuations in custom scripts |
| Previous Message | Tatsuo Ishii | 2015-09-04 05:04:05 | Re: BRIN INDEX value |