Re: Commitfest remaining "Needs Review" items

From: Heikki Linnakangas <hlinnakangas(at)pivotal(dot)io>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Jeff Davis <pgsql(at)j-davis(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com>, Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
Subject: Re: Commitfest remaining "Needs Review" items
Date: 2015-08-25 08:51:05
Message-ID: 55DC2C79.3090102@pivotal.io
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 08/25/2015 10:39 AM, Michael Paquier wrote:
> On Mon, Aug 10, 2015 at 4:34 PM, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>> Hello Hackers,
>>
>> There are a few "Needs Review" items remaining in the July commitfest.
>> Reviewers, please take action - you are holding up the commitfest.
>>
>> In addition to these items, there are a bunch of items in "Ready for
>> Committer" state. Committers: please help with those.
>
> At this stage, there are currently 26 patches in need of actions for
> the current CF:

Thanks Michael!

> - 12 patches are waiting on author:

These can all be marked as Returned with good conscience, they've gotten
at least some feedback.

> - 8 patches are in need of review:
> -- extends pgbench expressions with functions: bump to next CF, v9 has
> not been reviewed.
> -- check existency of table for -t option (pg_dump) when pattern has
> no wildcard: Bump to next CF?
> -- self-defined policy for sepgsql regression test, returned with
> feedback? The regressions are broken as mentioned at the end of the
> thread.
> -- Unique Joins: bump to next CF?
> -- improving join estimates using FK: bump to next CF?
> -- checkpoint continuous flushing, bump, work, performance tests and
> review are all still going on.
> -- Join pushdown support for foreign tables: err... This patch had no
> activity for 4 months.
> -- Reload SSL certificates on SIGHUP: returned with feedback? I think
> that this patch needs more work to be in a commitable state.
>
> - 6 patches marked as ready for committer:
> -- numeric timestamp in log_line_prefix
> -- plpgsql raise statement with context
> -- postgres_fdw: Options to set fetch_size at the server and table level.
> -- Improving test coverage of extensions with pg_dump
> -- New functions in sslinfo module
> -- CREATE EXTENSION ... CASCADE
>
> For all of them, bump to next CF with the same status if they are not
> committed at the end of the month?

Yeah, I don't think we can let this linger much longer. I hate to bump
patches in a commitfest just because no-one's gotten around to reviewing
them, because the point of commitfests is precisely to provide a
checkpoint where every submitted patch gets at least some feedback. But
I've run out of steam myself, and I don't see anyone else interested in
any of these patches, so I don't think there's much else we can do :-(.

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2015-08-25 08:51:10 Re: Reducing ClogControlLock contention
Previous Message Simon Riggs 2015-08-25 08:38:22 Re: Reducing ClogControlLock contention