Re: New functions

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Дмитрий Воронин <carriingfate92(at)yandex(dot)ru>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: New functions
Date: 2015-08-22 14:24:52
Message-ID: 55D88634.9050902@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 07/08/2015 01:15 PM, Дмитрий Воронин wrote:
> 07.07.2015, 18:34, "Michael Paquier" <michael(dot)paquier(at)gmail(dot)com>:
>
>> Speaking of which, I have rewritten the patch as attached. This looks
>> way cleaner than the previous version submitted. Dmitry, does that
>> look fine for you?
>> I am switching this patch as "Waiting on Author".
>
> Michael, hello. I'm looking your variant of patch. You create
> function ssl_extensions_info(), that gives information of SSL
> extensions in more informative view. So, it's cool.

Should check the return value of every OpenSSL call for errors. At least
BIO_new() could return NULL, but check all the docs of the others too.

Are all the functions used in the patch available in all the versions of
OpenSSL we support?

Other than those little things, looks good to me.

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2015-08-22 15:48:40 Re: PATCH: numeric timestamp in log_line_prefix
Previous Message Andres Freund 2015-08-22 14:14:48 Re: Reducing ClogControlLock contention