Re: Test code is worth the space

From: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>
To: Peter Geoghegan <pg(at)heroku(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Stark <stark(at)mit(dot)edu>, Noah Misch <noah(at)leadboat(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Test code is worth the space
Date: 2015-08-14 05:11:28
Message-ID: 55CD7880.6090602@BlueTreble.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 8/13/15 1:31 AM, Peter Geoghegan wrote:
> On Wed, Aug 12, 2015 at 11:23 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>>> The value of a core regression suite that takes less time to run has
>>> to be weighed against the possibility that a better core regression
>>> suite might cause us to find more bugs before committing. That could
>>> easily be worth the price in runtime.
>>
>>
>> Or have a quickcheck you run "all the time" and then run the bigger one once
>> before committing perhaps?
>
> I favor splitting the regression tests to add "all the time" and
> "before commit" targets as you describe. I think that once the
> facility is there, we can determine over time how expansive that
> second category gets to be.

I don't know how many folks work in a github fork of Postgres, but
anyone that does could run slow checks on every single push via
Travis-CI. [1] is an example of that. That wouldn't work directly since
it depends on Peter Eisentraut's scripts [2] that pull from
apt.postgresql.org, but presumably it wouldn't be too hard to get tests
running directly out of a Postgres repo.

[1] https://travis-ci.org/decibel/variant
[2] See wget URLs in
https://github.com/decibel/variant/blob/master/.travis.yml
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Data in Trouble? Get it in Treble! http://BlueTreble.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2015-08-14 07:32:38 Re: TAP tests are badly named
Previous Message Michael Paquier 2015-08-14 03:32:32 Re: In-core regression tests for replication, cascading, archiving, PITR, etc.