Re: buildfarm does not test "make check"

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: buildfarm does not test "make check"
Date: 2015-08-13 19:03:12
Message-ID: 55CCE9F0.2010602@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 08/13/2015 02:52 PM, Alvaro Herrera wrote:
>> You're also going to have to handle the msvc side of things. That won't be
>> trivial. See discussion elsewhere today about how we've got that wrong
>> recently.
> Oh my. The pg_upgrade code in src/tools/msvc/vcregress.pl looks rather
> unhealthy, and I don't see anything there to handle test_decoding, so I
> assume that's done differently somehow. (For pg_upgrade surely we should
> not be using a shell script ...)
>
> I don't have time to go through this right now, but it's on my list of
> things to think about.
>

Don't worry about the existing cases. Just create something that handles
new test cases in a generic way.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2015-08-13 20:20:00 Re: [BUG] CustomScan->custom_plans are not copied
Previous Message Alvaro Herrera 2015-08-13 18:52:48 Re: buildfarm does not test "make check"