Re: Tab completion for CREATE SEQUENCE

From: Vik Fearing <vik(at)2ndquadrant(dot)fr>
To: Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Brendan Jurd <direvus(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Tab completion for CREATE SEQUENCE
Date: 2015-08-12 13:22:40
Message-ID: 55CB48A0.6030709@2ndquadrant.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 08/04/2015 06:30 PM, Robert Haas wrote:
> On Mon, Aug 3, 2015 at 2:17 AM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> On Tue, Jul 7, 2015 at 9:14 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>>> On 2015-06-19 06:41:19 +0000, Brendan Jurd wrote:
>>>> I'm marking this "Waiting on Author". Once the problems have been
>>>> corrected, it should be ready for a committer.
>>>
>>> Vik, are you going to update the patch?
>>
>> Seeing no activity on this thread and as it would be a waste not to do
>> it, I completed the patch as attached. The following things are done:
>> - Fixed code indentation
>> - Removal of "RESTART", "SET SCHEMA", "OWNER TO", and "RENAME TO" in
>> CREATE SEQUENCE
>> - Added "START WITH".
>> - Added TEMP/TEMPORARY in the set of keywords tracked.
>> I am switching at the same time this patch as "Ready for committer".
>
> You didn't remove RESTART, so I did that. And this needed some more
> parentheses to make my compiler happy.
>
> Committed with those changes.

Thank you, Brendan, Michael, and Robert for taking care of this while I
was away.
--
Vik Fearing +33 6 46 75 15 36
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kouhei Kaigai 2015-08-12 14:18:08 Re: Foreign join pushdown vs EvalPlanQual
Previous Message Stephen Frost 2015-08-12 12:46:15 Re: Warnings around booleans