Re: tap tests remove working directories

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: tap tests remove working directories
Date: 2015-08-10 14:32:26
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 08/10/2015 09:55 AM, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> On 08/09/2015 08:58 PM, Michael Paquier wrote:
>>> Sure. Attached is what I have in mind. Contrary to your version we
>>> keep around temp paths should a run succeed after one that has failed
>>> when running make check multiple times in a row. Perhaps it does not
>>> matter much in practice as log files get removed at each new run but I
>>> think that this allows a finer control in case of failure. Feel free
>>> to have a look.
>> Actually, I don't think this is a very good idea. You could end up with
>> a whole series of opaquely named directories from a series of failing
>> runs. If you want to keep the directory after a failure, and want to do
>> another run, then rename the directory. That's what you have to do with
>> the main regression tests, too. My version also has the benefit of
>> changing exactly 3 lines in the source :-)
> FWIW, I think we should keep the behavior of the TAP tests as close as
> possible to the established behavior of the main regression tests.
> It's certainly possible that there's room for improvement in that
> benchmark behavior. But let's first converge the test behaviors,
> and then have a discussion about whether we want changes, and if
> so change all the tests at the same time.

Yeah. To do that we should probably stop using File::Temp to make the
directory, and just use a hardcoded name given to File::Path::mkpath. If
the directory exists, we'd just remove it first.

That won't be a very big change - probably just a handful of lines.



In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-08-10 14:48:48 Re: WIP: Rework access method interface
Previous Message Andres Freund 2015-08-10 14:12:54 Re: replication slot restart_lsn initialization