Re: [PATCH] Microvacuum for gist.

From: Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>
To: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Microvacuum for gist.
Date: 2015-08-03 14:34:39
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On Mon, Aug 3, 2015 at 12:27 PM, Anastasia Lubennikova
> <a(dot)lubennikova(at)postgrespro(dot)ru <mailto:a(dot)lubennikova(at)postgrespro(dot)ru>>
> wrote:
> 1) Test and results are in attachments. Everything seems to work
> as expected.
> 2) I dropped these notices. It was done only for debug purposes.
> Updated patch is attached.
> 3) fixed
> Good! Another couple of notes from me:
> 1) I think gistvacuumpage() and gistkillitems() need function-level
> comments.
> 2) ItemIdIsDead() can be used in index scan like it's done
> in _bt_checkkeys().
> ------
> Alexander Korotkov
> Postgres Professional:
> <>
> The Russian Postgres Company
I've added some comments.
ItemIdIsDead() is used now (just skip dead tuples as not matching the
And there is one else check of LSN in gistkillitems to make sure that
page was not changed between reads.

Anastasia Lubennikova
Postgres Professional:
The Russian Postgres Company

Attachment Content-Type Size
microvacuum_for_gist_3.patch text/plain 14.7 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2015-08-03 15:09:34 Re: RLS restrictive hook policies
Previous Message Fujii Masao 2015-08-03 14:31:52 track_commit_timestamp and COMMIT PREPARED