| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Oleksandr Shulgin <oleksandr(dot)shulgin(at)zalando(dot)de>, Josh Berkus <josh(at)agliodbs(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump quietly ignore missing tables - is it bug? |
| Date: | 2015-07-30 10:44:37 |
| Message-ID: | 55BA0015.2010703@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 07/25/2015 07:08 PM, Pavel Stehule wrote:
> I am sending a new patch - without checking wildcard chars.
The documentation says the option is called --strict-names, while the
code has --strict-mode. I like --strict-names more, "mode" seems
redundant, and it's not clear what it's strict about.
For symmetry, it would be good to also support this option in
pg_restore. It seems even more useful there.
Can we do better than issuing a separate query for each table/schema
name? The performance of this isn't very important, but still it seems
like you could fairly easily refactor the code to avoid that. Perhaps
return an extra constant for part of the UNION to distinguish which
result row came from which pattern, and check that at least one row is
returned for each.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2015-07-30 10:47:46 | Re: Using quicksort and a merge step to significantly improve on tuplesort's single run "external sort" |
| Previous Message | Etsuro Fujita | 2015-07-30 10:20:43 | Re: We need to support ForeignRecheck for late row locking, don't we? |