| From: | Joe Conway <joe(dot)conway(at)crunchydata(dot)com> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: more RLS oversights |
| Date: | 2015-07-29 16:52:13 |
| Message-ID: | 55B904BD.5040404@crunchydata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 07/29/2015 08:46 AM, Joe Conway wrote:
> On 07/29/2015 01:01 AM, Dean Rasheed wrote:
>> The CreatePolicy() and AlterPolicy() changes look OK to me, but the
>> RemovePolicyById() change looks to be unnecessary ---
>> RemovePolicyById() is called only from doDeletion(), which in turned
>> is called only from deleteOneObject(), which already invokes the drop
>> hooks. So ISTM that RemovePolicyById() doesn't need to do anything,
>> right?
>
> Seems correct. Will remove that change and commit it that way.
Pushed to HEAD and 9.5.
Joe
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-07-29 16:54:59 | Re: Reduce ProcArrayLock contention |
| Previous Message | Dean Rasheed | 2015-07-29 16:40:18 | Re: more RLS oversights |