Re: spgist recovery assertion failure

On 07/27/2015 04:24 PM, Michael Paquier wrote:
> On Mon, Jul 27, 2015 at 2:33 PM, Piotr Stefaniak
> <postgres(at)piotr-stefaniak(dot)me> wrote:
>> On 07/27/2015 07:19 AM, Michael Paquier wrote:
>>>
>>> On Mon, Jul 27, 2015 at 2:00 PM, Noah Misch <noah(at)leadboat(dot)com> wrote:
>>>>
>>>> When I caused a crash during the create_index regression test, recovery
>>>> hit an
>>>> assertion failure. Minimal test case:
>>>>
>>>> psql -X <<EOSQL
>>>> CREATE TABLE t (c text);
>>>> INSERT INTO t SELECT 'P0123456789abcdef' FROM generate_series(1,1000);
>>>> INSERT INTO t VALUES ('P0123456789abcdefF');
>>>> CREATE INDEX ON t USING spgist (c);
>>>> EOSQL
>>>> pg_ctl -m immediate -w restart
>>>
>>>
>>> On which platform are you seeing the failure? I am afraid I could not
>>> reproduce the failure on Linux and OSX after testing it on HEAD.
>>>
>>
>> I'm having the same symptoms with
>> 159cff58cf3b565be3c17901698a74238e9e23f8 on Ubuntu Linux 3.4.39 armv7l.
>
> Yes, on armv7l this can be indeed reproduced.

Fixed, thanks everyone! The problem was that in the WAL format change
patch, I had used "char" in a struct to hold -1, but "char" is unsigned
on PowerPC and ARM.

- Heikki