| From: | Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Guillaume Lelarge <guillaume(at)lelarge(dot)info>, mail(at)bwe(dot)im, Oleksandr Shulgin <oleksandr(dot)shulgin(at)zalando(dot)de>, PostgreSQL Bugs List <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #12379: pgbench should hint to pgbench -i |
| Date: | 2015-07-18 16:16:09 |
| Message-ID: | 55AA7BC9.6090307@dalibo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 18/07/2015 13:49, Fabien COELHO wrote:
>
> Hello Julien,
>
>> Here's a v7 patch which display the hint only if SQLSTATE is
>> ERRCODE_UNDEFINED_TABLE and use the message Tom suggested, as there
>> wasn't any better suggestion or strong objection with it in the other
>> thread.
>
> I'm wondering why you added the define. Isn't-there some convenient
> include to get errcode definitions?
>
IIRC correctly, you have to include postgres.h for that. I supposed it
was better to define it than adding such an include, since it shouldn't
change and it's already done like this in vacuumdb.c.
--
Julien Rouhaud
http://dalibo.com - http://dalibo.org
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-07-18 16:32:31 | Re: BUG #12379: pgbench should hint to pgbench -i |
| Previous Message | Michael Bommarito | 2015-07-18 16:09:55 | Re: BUG #13490: Segmentation fault on pg_stat_activity |