| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | "Shulgin, Oleksandr" <oleksandr(dot)shulgin(at)zalando(dot)de>, Ryan Pedela <rpedela(at)datalanche(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, hlinnaka <hlinnaka(at)iki(dot)fi>, Merlin Moncure <mmoncure(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Generalized JSON output functions |
| Date: | 2015-07-17 14:31:47 |
| Message-ID: | 55A911D3.8070408@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 07/17/2015 10:11 AM, Andrew Dunstan wrote:
>
> On 07/17/2015 08:20 AM, Shulgin, Oleksandr wrote:
>
>
>> > This patch makes Postgres core more complex
>>
>> Yes, it does. But, that was not the purpose, obviously. :-)
>>
>> > while not really solving the problem in Javascript.
>>
>> It still allows for less risk of silent data corruption on the js side.
>>
>>
>
> I have already pointed out how this patch is fundamentally broken. You
> can achieve your aims by a fairly small amount of code inside your
> logical decoder, and with no core code changes whatsoever. So I'm
> puzzled why we are even still debating this broken design.
Incidentally, this doesn't look acceptable anyway:
> ! es->json_cxt.value(&es->json_cxt, num, JSONTYPE_NUMERIC,
> ! NUMERICOID, 1702 /* numeric_out */);
We don't hardcode function oids elsewhere. So this is also something
that makes the patch unacceptable.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-07-17 14:37:44 | Re: segfault in 9.5alpha - plpgsql function, implicit cast and IMMUTABLE cast function |
| Previous Message | Alvaro Herrera | 2015-07-17 14:30:36 | Re: [PATCH] Generalized JSON output functions |